Review Request: Window runner to switch windows and desktops

[Ryan Bitanga]

> On 2009-07-24 12:06:13, Ryan Bitanga wrote:
> > When displaying a matching window, I think it would be better to display the icon of the window itself and not a generic icon for all matches just like what the windows runner in playground does.
> > 
> > It might also help to make the window keyword optional to make it easier to switch between windows.
> > 
> > And lastly, you might want to implement actions like minimize, maximize, etc. The one in playground does this by relying on libtaskmanager. :)
> 
> Martin Gräßlin wrote:
>     > When displaying a matching window, I think it would be better to display the icon of the window itself and not a generic icon for all matches just like what the windows runner in playground does.
>     I really had problems with showing the icon - basically krunner kept crashing. I will have a look on the one in playground (didn't know there was alreaydy a runner). Nevertheless I think it's a good idea to have a generic icon to indicate it's not to start the application.
>     
>     > It might also help to make the window keyword optional to make it easier to switch between windows.
>     That is possible, but you cannot use the restrictions like class, role and desktop
>     
>     > And lastly, you might want to implement actions like minimize, maximize, etc. The one in playground does this by relying on libtaskmanager. :)
>     Not sure if it is really useful and no need to rely on libtaskmanager. KWindowSystem provides everything you need :-)

I suppose it's just a matter of preference but you can use match subtext to differentiate open windows from launching another application.

I skimmed through the code so I missed that you match window names when no keyword is used so my second suggestion is unnecessary :)

And while it isn't necessary to depend on libtaskmanager, it makes it easier in that you don't have to write your own slots/methods/additional if clauses for maximizing, minimizing, making windows sticky, etc. :)


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1114/#review1732
-----------------------------------------------------------


On 2009-07-24 09:14:52, Martin Gräßlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1114/
> -----------------------------------------------------------
> 
> (Updated 2009-07-24 09:14:52)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This runner lists the windows and virtual desktops. It allows to activate a selected window or switch to a selected desktop. The runner works in the following way:
>  * input is matched on window name, class or role; matching windows are listed
>  * input is matched on desktop name. Matching desktops are shown for switching to, all windows on matching desktops are listed.
>  * keyword "desktop": lists all desktops (except current) if additional number is inserted the list is reduced to that desktop
>  * keyword "window": lists all windows. Additional text will be used to restrict like in first case. Following sub queries to restrict search are possible:
>    * name=: restrict on name
>    * class=: restrict on window class
>    * role=: restrict on window role
>    * desktop=: restrict on desktop
>   those subqueries can be combined in any order. Each input not containing a '=' will be interpreted as a name restriction if there is no explicit name restriction. In that case it's ignored. Example query: "window desktop=2 class=kmail role=composer" will list all open KMail composer windows on desktop 2.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/runners/CMakeLists.txt 1000707 
>   trunk/KDE/kdebase/workspace/plasma/runners/windows/CMakeLists.txt PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/runners/windows/plasma-runner-windows.desktop PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/runners/windows/windowsrunner.h PRE-CREATION 
>   trunk/KDE/kdebase/workspace/plasma/runners/windows/windowsrunner.cpp PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1114/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>