[PATCH] BUG 189643 Taskbar should be animated while program is starting

Aaron J. Seigo aseigo at kde.org
Thu Jul 23 19:33:56 CEST 2009


On Thursday 23 July 2009, 潘卫平(Peter Pan) wrote:
> Taht will cover the icon and looks mussy.
> I prefer to let it over the text.

hm.. ok, how about on the right side of the button then, where the # of 
windows usually appears when there are several windows grouped?

also as for this:

+    QRectF rect = parentGroup()->tasksLayout()->contentsRect();
+    int rowCount = parentGroup()->tasksLayout()->rowCount();
+    qreal height = rect.height() / rowCount; 
+    QSizeF size(height, height);

it should be able to just position it relative to the task button itself, 
something like this which would make it consistent with the group number 
drawing as well:

Plasma::FrameSvg *itemBackground = m_applet->itemBackground();
QSizeF busySize(itemBackground->elementSize(expanderElement()));
QRectF animationRect(QPointF(size().width() - busySize.width(), (size.height() 
- busySize.height())  / 2), busySize);

even with this code, however, if the size of the button changes while the app 
is launching the busy widget will no longer be in the right place.

so ... either the positioning code should be put into a separate method and be 
called from both startStartupAnimation and resizeEvent or a layout should be 
used to manage that for us. a layout is probably overkill in this situation, 
though.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090723/08c93ce7/attachment.sig 


More information about the Plasma-devel mailing list