Review Request: windows port of taskmanager library
Patrick Spendrin
ps_ml at gmx.de
Thu Jul 23 01:57:29 CEST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1101/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
I want to add some missing functionality to the taskmanager library on the windows platform. As the code has some more X11 dependencies, I decided to make up two files for tasks.cpp which contain the functions that differ on Windows and X11.
The only thing that should affect X11-builds in the end should be the change from class to struct for QUuid.
There should be no other changes regarding the X11 platform.
Diffs
-----
trunk/KDE/kdebase/workspace/libs/CMakeLists.txt 1000690
trunk/KDE/kdebase/workspace/libs/taskmanager/task.h 1000690
trunk/KDE/kdebase/workspace/libs/taskmanager/task.cpp 1000690
trunk/KDE/kdebase/workspace/libs/taskmanager/task_win.cpp PRE-CREATION
trunk/KDE/kdebase/workspace/libs/taskmanager/task_x11.cpp PRE-CREATION
trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.h 1000690
trunk/KDE/kdebase/workspace/libs/taskmanager/taskmanager.cpp 1000690
Diff: http://reviewboard.kde.org/r/1101/diff
Testing
-------
I tested this on windows with both gcc and msvc compilers.
Thanks,
Patrick
More information about the Plasma-devel
mailing list