Gethotnewstuff and themes

Marco Martin notmart at gmail.com
Wed Jul 22 21:57:49 CEST 2009


Hi all,
another commit to blame, another really ugly patch lacking a proper solution 
:p

the commit is the following one
http://websvn.kde.org/trunk/KDE/kdebase/workspace/plasma/shells/desktop/backgrounddialog.cpp?r1=963647&r2=969465

the problem is: most of the themes downloaded with gethotnewstuff have a 
folder name different from plugin name, so Theme::findIntheme doesn't work, 
for instance, our all time favourite, fluffy bunny has FluffyBunny as plugin 
name and fluffybunny as folder name.
the old behaviour of the desktop settings dialog was simply using the folder 
name, so it always worked, now most themes are simply broken.

Now the question is: simply say to those theme screw you and make the 
package right or reverting to the old behaviour? (attached patch does it in a 
not too nice way but with minimal change)

i would like to force things to be correct, but retrocompatibility is 
important too, hmm
-- 
Marco Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: themename.diff
Type: text/x-patch
Size: 1176 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090722/c362e9c2/attachment.diff 


More information about the Plasma-devel mailing list