Review Request: Custom combo boxes for Plasma::ComboBox

[Michal Dutkiewicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1094/
-----------------------------------------------------------

Review request for Plasma and Marco Martin.


Summary
-------

This patch adds possibility to use custom combo box widgets (subclassed from KComboBox) instead of plain KComboBox.
It's intended for 4.3 (better later than never..., didn't know that there is still no possibility to do something like this and no possibility to create custom Plasma themed widget).
It adds new constructor to set widget without creating new like in first.
It will be used by Run Command applet (KHistoryComboBox, waiting for theming possibility for very long time) and probably by others in the future.
If it will be accepted I'll probably prepare similar patches to some other widgets (most common) for consistency and bigger flexibility that comes without costs (as far as I know).


Diffs
-----

  /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1000582 
  /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1000582 

Diff: http://reviewboard.kde.org/r/1094/diff


Testing
-------

Tested by my friend, compiles and works.


Screenshots
-----------

Plasma themed KHistoryComboBox in Run Command applet
  http://reviewboard.kde.org/r/1094/s/151/


Thanks,

Michal