Review Request: Krunner default interface doesn't display centered when the user have more than one screen (desktop extended).

[Alex Fiestas]

> On None, Aaron Seigo wrote:
> > i actually have a patch around here that i wrote while on route to vancouver that fixes the x resolution change ... as for always calling centerOnScreen when it is shown, that was previous behaviour but then it was removed so people could re-arrange it. what really needs to happen, i think, is to preserve per-screen positioning.
> 
> Alex Fiestas wrote:
>     I saw the commit, I'll test it right now, and I'll leave the feedback in a few places (so you can reach it quickly and backport it to 4.3 if possible).

The patch works fantastic with 2 screens and desktop extended, so for my part (as tester) to backport it to kde 4.3!


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1089/#review1687
-----------------------------------------------------------


On 2009-07-20 17:50:04, Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1089/
> -----------------------------------------------------------
> 
> (Updated 2009-07-20 17:50:04)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Just a centerOnScreen call before show the default interface, this is needed to have the correct behavior when the user have the desktop extended (numScreens() > 1).
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 999534 
> 
> Diff: http://reviewboard.kde.org/r/1089/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex
> 
>