Review Request: Theme caching smartification

Aaron Seigo aseigo at kde.org
Mon Jul 20 19:51:11 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1055/#review1688
-----------------------------------------------------------

Ship it!


- Aaron


On 2009-07-18 17:46:17, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1055/
> -----------------------------------------------------------
> 
> (Updated 2009-07-18 17:46:17)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch follows what we talked about on the performance issue thread (bug 200313 by the way) on the ml.
> we now have a new method that is delayed, with a new "id" parameter that is used as key to discard the too short lived sizes
> 
> oh, and the @since is 4.3, yeah, adding a function in 4.3 right now is a bit gross but i don't see other ways
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/framesvg.cpp 995762 
>   /trunk/KDE/kdelibs/plasma/svg.cpp 995762 
>   /trunk/KDE/kdelibs/plasma/theme.h 995762 
>   /trunk/KDE/kdelibs/plasma/theme.cpp 995762 
> 
> Diff: http://reviewboard.kde.org/r/1055/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>



More information about the Plasma-devel mailing list