Review Request: Fixing Bball getting stuck at the corner

Aaron J. Seigo aseigo at kde.org
Mon Jul 20 19:44:05 CEST 2009


On Sunday 19 July 2009, Michael Jansen wrote:
> On Sunday 19 July 2009 02:55:06 Sebastian Kügler wrote:
> > On Sunday 19 July 2009 02:16:13 Omer F. USTA wrote:
> > > Hi , just to learn why "or" instead of common "||" ? in
> > >   if (m_bottom_right == 1 or m_bottom_left == 1) {
> >
> > I personally find "or" more readable, though I think || is more common in
> > KDE code. Maybe there are some compiler intricacies to it.
> >
> > Otherwise I don't really know, I guess a convention is better than no
> > convention for code, and we just went with ||.
>
> David once told me we support compilers that do not understand 'and' and
> 'or'.

regardless, for consistency use || and && since that's used everywhere else. 
there's no compelling benefit to "or" and "and" other than to make the code 
less consistent.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090720/5e0e7872/attachment.sig 


More information about the Plasma-devel mailing list