Review Request: Fixing Bball getting stuck at the corner

[Omer F. USTA]

> On 2009-07-19 00:16:17, Omer F. USTA wrote:
> > Hi , just to learn why "or" instead of common "||" ? in 
> >   if (m_bottom_right == 1 or m_bottom_left == 1) {
> 
> Sujith  H wrote:
>     I changed it to '||'.

This looks committed with r999070 and r999083
it will be nice to mark as "submitted"


- Omer F.


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1054/#review1655
-----------------------------------------------------------


On 2009-07-17 23:37:46, Sujith  H wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1054/
> -----------------------------------------------------------
> 
> (Updated 2009-07-17 23:37:46)
> 
> 
> Review request for Plasma, Aaron Seigo, Artur de Souza (MoRpHeUz), and Sebastian Kügler.
> 
> 
> Summary
> -------
> 
> The Bball gets stuck at the right-bottom/left-bottom. Now with this patch it doesn't stuck. I had added a feature that when dropped from right/left top will make the ball bounce.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdeplasma-addons/applets/bball/bball.h 998542 
>   /trunk/KDE/kdeplasma-addons/applets/bball/bball.cpp 998542 
> 
> Diff: http://reviewboard.kde.org/r/1054/diff
> 
> 
> Testing
> -------
> 
> Tested in my laptop and works fine here.
> 
> 
> Thanks,
> 
> Sujith
> 
>