Review Request: Krunner default interface doesn't display centered when the user have more than one screen (desktop extended).

[Alex Fiestas]

> On 2009-07-20 10:39:52, Jacopo De Simoi wrote:
> > What does exactly happen when the user have more than one screen? 
> > Where does krunner show up in that case? on the wrong desktop?
> > 
> > We removed the centerOnScreen on display to allow the user to move around the krunner window during a session; so centerOnScreen now assumes it's only called by the ctor.

There are two wrong behaviors imho:
1-Krunner always is showed at the same screen.
2-If the X resolution changes (adding a screen for example), the QRect is not updated (so Krunner is misplaced). 

The first point is kinda critical, because usually you're focused (watching?) the screen that contains the mouse, so if krunner appear outside your view angle, you've to mouse your head and that's so annoying :(

Then, the second point could be a different bug, I guess I can provide a patch for that.


- Alex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1089/#review1674
-----------------------------------------------------------


On 2009-07-20 10:14:59, Alex Fiestas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1089/
> -----------------------------------------------------------
> 
> (Updated 2009-07-20 10:14:59)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Just a centerOnScreen call before show the default interface, this is needed to have the correct behavior when the user have the desktop extended (numScreens() > 1).
> 
> 
> Diffs
> -----
> 
>   svn://anonsvn.kde.org/home/kde/trunk/KDE/kdebase/workspace/krunner/interfaces/default/interface.cpp 999534 
> 
> Diff: http://reviewboard.kde.org/r/1089/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex
> 
>