Review Request: Fix text centering in task manager task items

[Alec Moskvin]

On Sunday 19 July 2009 04:11:04, Marco Martin wrote:
> On 7/19/09, Alec Moskvin <alecm at gmx.com> wrote:
> > On Saturday 18 July 2009 13:35:46, Marco Martin wrote:
> >> Ship it!
> >
> > Great! How do I do that? :)
>
> if you don't have a svn account i can do that.

Please do. If it's still possible to add it to 4.3.0, that would be really 
nice.

> if you really (really:p) plan to stick around you can apply for one, see
> http://techbase.kde.org/Contribute/Get_a_SVN_Account

If only I had a little more free time :(

> >> to me is fine, at least for now. i've tried with every conceivable
> >
> > thing
> >
> >> but this is the only thing that seems kinda work
> >>
> >> - Marco
> >>
> >> On 2009-07-18 17:03:45, Alec Moskvin wrote:
> >> > -----------------------------------------------------------
> >> > This is an automatically generated e-mail. To reply, visit:
> >> > http://reviewboard.kde.org/r/980/
> >> > -----------------------------------------------------------
> >> >
> >> > (Updated 2009-07-18 17:03:45)
> >> >
> >> >
> >> > Review request for Plasma.
> >> >
> >> >
> >> > Summary
> >> > -------
> >> >
> >> > This patch properly aligns text to the drawable rectangle, thus
> >> > preventing any part of the text from being cut off if there is still
> >> > space available.
> >> >
> >> > It removes two things:
> >> >
> >> > - Code that sets the text at (0, 0) if the "text" is larger than the
> >> > rectangle (which is not correct since there is additional interline
> >> > spacing added to top and bottom which need not be shown)
> >> >
> >> > - The part where it for some strange reason lowers all the text
> >
> > by the
> >
> >> > difference between the height of the 'M' and the 'x', thus
> >
> > pushing it out
> >
> >> > of the drawable area.
> >> >
> >> >
> >> > This addresses bug 178776.
> >> >     https://bugs.kde.org/show_bug.cgi?id=178776
> >> >
> >> >
> >> > Diffs
> >> > -----
> >
> > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp
> >
> >> > 987462
> >> >
> >> > Diff: http://reviewboard.kde.org/r/980/diff
> >> >
> >> >
> >> > Testing
> >> > -------
> >> >
> >> > Compiled it on my machine - it works well with task manager of
> >
> > any size.
> >
> >> > Screenshots
> >> > -----------
> >> >
> >> > Different sized taskbars with patch 2.
> >> >   http://reviewboard.kde.org/r/980/s/150/
> >> >
> >> >
> >> > Thanks,
> >> >
> >> > Alec
> >
> > _______________________________________________
> > Plasma-devel mailing list
> > Plasma-devel at kde.org
> > https://mail.kde.org/mailman/listinfo/plasma-devel
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel