Review Request: ui to add plasmoids on the systray

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1011/#review1628
-----------------------------------------------------------

Ship it!


i think this is a fine start; it would also be nice to be able to drag applets in eventually, but this control makes sense given the other controls already there.

- Aaron


On 2009-07-13 20:59:30, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1011/
> -----------------------------------------------------------
> 
> (Updated 2009-07-13 20:59:30)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> this adds a config dialog with a list of plasmoids that are "supported" (with supported means they have X-Plasma-NotificationArea=true in their desktop file)
> this comes after a chat an evening at akademy with richmoore and ruphy, what emerged is that it really makes no sense to have support for every applet (a taskbar in the systray? hmm.. no :))
> i usually don't like adding new config dialogs but i think this is kinda necessary.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/CMakeLists.txt 995268 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/core/manager.h 995268 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/core/manager.cpp 995268 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/plasmoid/plasmoidtask.cpp 995268 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/plasmoid/plasmoidtaskprotocol.h 995268 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/protocols/plasmoid/plasmoidtaskprotocol.cpp 995268 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp 995268 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/plasmoidtasks.ui PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/1011/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>