ginormous performance issue

[Aaron J. Seigo]

On Wednesday 15 July 2009, Marco Martin wrote:
> a way could be like now, parsing the key and throwing away other sizes of
> the same framesvg, or just revert that commit...

i think the patch you attached will also kill other valid pixmaps to be 
cached: two plasmoids with the same svg but rendered at different sizes == 
only one gets cached == not good.

sooo .. yes, that commit should probably just be reverted. unfortunate, as it 
means more overhead per FrameSvg object which is something that is used quite 
a lot.

some per-caching-object accounting in Theme could help prevent this (and 
others from falling into the same trap) but that's more work and similar 
overhead (not to mention API changes)...

+1 on reverting.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090715/a500bc1c/attachment.sig