Review Request: Patch to support Plasma::PopupApplets in scriptengines

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/964/#review1598
-----------------------------------------------------------

Ship it!


this actually changes the behaviour of popupapplet, so now is possible to actually set a widget besides reimplementing graphicsWidget() hmm...
i think it should have been this way since the beginning (the api of popupapplet is a ctually a bit... sad, but well..) and i like this change, even for c++ applets too..
however, since is still possible to reimplement graphicswidget, this makes setGraphicsWidget useless in those cases, but i guess it depends from the brokeness of popupapplet api in first place, so let's go for it i would say..

- Marco


On 2009-07-14 19:23:26, Richard Dale wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/964/
> -----------------------------------------------------------
> 
> (Updated 2009-07-14 19:23:26)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Add getters and setters for PopupApplet::widget() and PopupApplet::graphicsWidget() for use in scripting languages. Add a initScriptingExtenderItem() signal for script engines to connect to and call their versions of Applet::initExtenderItem()
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/applet.h 996721 
>   trunk/KDE/kdelibs/plasma/applet.cpp 996702 
>   trunk/KDE/kdelibs/plasma/popupapplet.h 996702 
>   trunk/KDE/kdelibs/plasma/popupapplet.cpp 996702 
>   trunk/KDE/kdelibs/plasma/private/popupapplet_p.h 996702 
> 
> Diff: http://reviewboard.kde.org/r/964/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Richard
> 
>