Review Request: Moonrise/set for time dataengine

[Petri Damstén]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/680/
-----------------------------------------------------------

(Updated 2009-07-06 06:02:10.326719)


Review request for Plasma.


Changes
-------

Update patch to current trunk. Updates also bbc ion to use dataengine directly (if lib is better I can update the patch).


Summary
-------

Moonrise/set patch using new TimeSource in time dataengine. This also changes all sun and moon phase calculation code so same code can be used for all the calculations. This is too late for 4.3, but I'll post it here so it won't get lost.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/CMakeLists.txt 992178 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/dataengineconsumer.h PRE-CREATION 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_bbcukmet.h 992178 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_bbcukmet.cpp 992178 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarsystem.h PRE-CREATION 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarsystem.cpp PRE-CREATION 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/time_solar_export.h 992178 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.h 992178 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/timesource.cpp 992178 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarposition.h 992178 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/solarposition.cpp 992178 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/CMakeLists.txt 992178 
  /trunk/KDE/kdebase/workspace/plasma/dataengines/time/phases.cpp 992178 

Diff: http://reviewboard.kde.org/r/680/diff


Testing
-------


Thanks,

Petri