[PATCH] BUG 198888 & BUG 198890 about icon and text on plasma tooltip

[潘卫平]

2009/7/5 Aaron J. Seigo <aseigo at kde.org>

> On Saturday 04 July 2009, 潘卫平 wrote:
> > BUG 198888 plasma applet tasks doesn't have an icon on tooltip, because
> we
> > don't set an icon in TaskGroupItem updateTooltip function. Apply
> > kdebase-plasma-tasks-groupicon.patch to
> > kdebase/workspace/plasma/applets/tasks/ can fix this bug.
>
> yes, that's a good addition.
>
> > BUG 198890 The positions of icon and text on plasma tooltip aren't
> > consistent when grouping or not, because the plasma tooltip only has a
> > . When you enable kwin taskbar thumbnail effect, it cann't work
> > finefor previews, icon and text.
> >
> > So I add previews into a QHBoxLayout, add icon and text into another
> > QHBoxLayout, and set the stretch factor of text is 1, and and both
> > QHBoxLayouts into a QVBoxLayout. These make the items on tooltip looks
> > consistent. kdelibs-tooltip-alignment.patch should be applied to
> > kdelibs/plasma/.
>
> while the patch looks ok, there's no reason the exact same thing couldn't
> be
> done with a QGridLayout. it also supports setting the stretch, alignment,
> etc.
>
> by the way, do you have a commit account for KDE's svn? if you do, please
> commit the above patches (and close the bugs on bugs.kde.org :). if you
> don't,
> please visit http://techbase.kde.org/Contribute/Get_a_SVN_Account and
> apply
> for one as it is best if you can commit these kinds of patches directly
> yourself. :)
>
> --
> Aaron J. Seigo
> humru othro a kohnu se
> GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43
>
> KDE core developer sponsored by Qt Software
>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>

Yes, QGridLayout can do this too.

And I have applied for a SVN account just now. Thanks for your
encouragement!

-- 
潘卫平(Peter Pan)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/plasma-devel/attachments/20090705/70e99468/attachment.htm