Review Request: Fix Open Picture.... menu behavior in Picture Frame applet
Chani
chanika at gmail.com
Thu Jul 2 22:09:07 CEST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/926/#review1442
-----------------------------------------------------------
trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp
<http://reviewboard.kde.org/r/926/#comment892>
that if statement is getting awfully long. perhaps for the sake of readability you could split it up a bit with a bool or two? :)
- Chani
On 2009-07-02 09:15:41, Shantanu Tushar Jha wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/926/
> -----------------------------------------------------------
>
> (Updated 2009-07-02 09:15:41)
>
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Picture Frame didn't have Open Picture... option when a new Picture Frame is added and Slideshow is enabled. This patch fixes the problem.
>
>
> Diffs
> -----
>
> trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 990276
>
> Diff: http://reviewboard.kde.org/r/926/diff
>
>
> Testing
> -------
>
> Tried on frame applet svn build with the patch. Works fine for me.
>
>
> Thanks,
>
> Shantanu
>
>
More information about the Plasma-devel
mailing list