Review Request: a messagebox for applets

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/327/
-----------------------------------------------------------

(Updated 2009-01-22 08:09:50.074283)


Review request for Plasma.


Summary
-------

this adds Applet::setMessage("icon", "message", buttons)
pressing any button (if any ) makes message go away and emit messageButtonPressed(button) since we'll keep things async
settings a message also makes the thing go away (useful for messages without buttons and let's keep the api little:)

what still has to be ironed out i think is KDialog::ButtonCode that probably needs to be replaced with a similar enum internal to plasma (having to include kdialog for this thing that is not really it sounds ugly)

and aalso the quite bovine way to discover what button was pressed (no idea how to prettify that at the moment)

update:now plasma has its own enum for buttons, i think for a start at least api-wise could be good, it remains to do (but in a second moment) the move on popup in case of popupapplets
update2: api is a bit nicer


Diffs
-----

  /trunk/KDE/kdelibs/plasma/applet.h
  /trunk/KDE/kdelibs/plasma/applet.cpp
  /trunk/KDE/kdelibs/plasma/plasma.h

Diff: http://reviewboard.vidsolbach.de/r/327/diff


Testing
-------


Thanks,

Marco