Review Request: Twitter ImageSource no more a singleton
Marco Martin
notmart at gmail.com
Wed Jan 21 22:43:10 CET 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/340/
-----------------------------------------------------------
Review request for Plasma.
Summary
-------
Why? the problem was that now twitter applet/dataengine supports different services.
if you have different applets loaded at the same time on different services and following people with the same nick, their avatars will appear mixed up, for instance the identica avatars on the applet on twitter (depends what is the last applet that finished images download)
so now the username at server is used in the image source name (well, actually the username@ could be useless i think...)
Diffs
-----
/trunk/KDE/kdeplasma-addons/applets/twitter/twitter.h
/trunk/KDE/kdeplasma-addons/applets/twitter/twitter.cpp
/trunk/KDE/kdeplasma-addons/dataengines/twitter/imagesource.h
/trunk/KDE/kdeplasma-addons/dataengines/twitter/imagesource.cpp
/trunk/KDE/kdeplasma-addons/dataengines/twitter/timelinesource.h
/trunk/KDE/kdeplasma-addons/dataengines/twitter/timelinesource.cpp
/trunk/KDE/kdeplasma-addons/dataengines/twitter/twitterengine.h
/trunk/KDE/kdeplasma-addons/dataengines/twitter/twitterengine.cpp
Diff: http://reviewboard.vidsolbach.de/r/340/diff
Testing
-------
Thanks,
Marco
More information about the Plasma-devel
mailing list