Review Request: Show wallpaper resolution if possible in selection dialog

[Beat Wolf]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/332/
-----------------------------------------------------------

(Updated 2009-01-19 10:07:16.022596)


Review request for Plasma.


Summary
-------

Partially solves the wish: http://bugs.kde.org/show_bug.cgi?id=177087
If possible, shows the resolution of a wallpaper. For wallpaper packages, the best resolution the package can provide will be shown

In the screenshot, only the last wallpaper is a single image where the resolution can be shown.

Update:
updated diff with the suggestion, don't have time to take a screenshot, but all the resolutions are shown

Update2:
added correct screenshot

Update3:
implemented the proposed updates. The patch is now much faster indeed.


Diffs
-----

  trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundlistmodel.cpp
  trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundpackage.h
  trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundpackage.cpp
  trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgrounddelegate.h
  trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgrounddelegate.cpp
  trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundlistmodel.h
  trunk/KDE/kdebase/workspace/plasma/wallpapers/image/image.cpp

Diff: http://reviewboard.vidsolbach.de/r/332/diff


Testing
-------


Screenshots
-----------


  http://reviewboard.vidsolbach.de/r/332/s/106/


Thanks,

Beat