Review Request: a messagebox for applets

Marco Martin notmart at gmail.com
Sun Jan 18 19:35:15 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/327/
-----------------------------------------------------------

(Updated 2009-01-18 10:35:15.862683)


Review request for Plasma.


Summary
-------

this adds Applet::setMessage("icon", "message", buttons)
pressing any button (if any ) makes message go away and emit messageButtonPressed(button) since we'll keep things async
settings a message also makes the thing go away (useful for messages without buttons and let's keep the api little:)

what still has to be ironed out i think is KDialog::ButtonCode that probably needs to be replaced with a similar enum internal to plasma (having to include kdialog for this thing that is not really it sounds ugly)

and aalso the quite bovine way to discover what button was pressed (no idea how to prettify that at the moment)


Diffs
-----

  /trunk/KDE/kdelibs/plasma/plasma.h
  /trunk/KDE/kdelibs/plasma/applet.h
  /trunk/KDE/kdelibs/plasma/applet.cpp

Diff: http://reviewboard.vidsolbach.de/r/327/diff


Testing
-------


Thanks,

Marco



More information about the Plasma-devel mailing list