Review Request: Show wallpaper resolution if possible in selection dialog

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/332/#review322
-----------------------------------------------------------



trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundpackage.cpp
<http://reviewboard.vidsolbach.de/r/332/#comment271>

    still reading in the image here (slow). try:
    
    KFileMetaInfo info(m_file, QString(), KFileMetaInfo::TechnicalInfo);
    m_sizeCache = QSize(info.item("width").value().toInt(),
                        info.item("height").value().toInt());
    
    
    i *think* the keys are width and height; you may need to do a run through info.keys() to check what is there if i'm wrong. =) you may also need ContentInfo instead of TechnicalInfo. i'm not overly familiar with the details of the kde4 changes to KFileMetaInfo =) but yes, that's the general idea at least ;)



trunk/KDE/kdebase/workspace/plasma/wallpapers/image/image.cpp
<http://reviewboard.vidsolbach.de/r/332/#comment272>

    whitespace


- Aaron


On 2009-01-18 01:21:31, Beat Wolf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/332/
> -----------------------------------------------------------
> 
> (Updated 2009-01-18 01:21:31)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Partially solves the wish: http://bugs.kde.org/show_bug.cgi?id=177087
> If possible, shows the resolution of a wallpaper. For wallpaper packages, the best resolution the package can provide will be shown
> 
> In the screenshot, only the last wallpaper is a single image where the resolution can be shown.
> 
> Update:
> updated diff with the suggestion, don't have time to take a screenshot, but all the resolutions are shown
> 
> Update2:
> added correct screenshot
> 
> Update3:
> implemented the proposed updates. The patch is now much faster indeed.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgrounddelegate.h
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgrounddelegate.cpp
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundlistmodel.h
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundlistmodel.cpp
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundpackage.h
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundpackage.cpp
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/image.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/332/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.vidsolbach.de/r/332/s/106/
> 
> 
> Thanks,
> 
> Beat
> 
>