Review Request: Show wallpaper resolution if possible in selection dialog

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/332/#review320
-----------------------------------------------------------


only blocker i see is the performance issue, which should be easy to fix.


trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundlistmodel.cpp
<http://reviewboard.vidsolbach.de/r/332/#comment266>

    you could also do:
    
    QString("%1x%2").arg(size.width()).arg(size.height());
    
    perhaps a bit more readable, but really hardly matters as long as it works =)



trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundlistmodel.cpp
<http://reviewboard.vidsolbach.de/r/332/#comment265>

    should be on the same line.



trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundpackage.cpp
<http://reviewboard.vidsolbach.de/r/332/#comment267>

    we probably don't want to load *every* image as that could be very, very slow. findBackground already checks against the size, so even just copy the essence of that code into this method.



trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundpackage.cpp
<http://reviewboard.vidsolbach.de/r/332/#comment268>

    this could probably use KFileMetaInfo which should be a lot faster than actually loading the whole image off disk.



trunk/KDE/kdebase/workspace/plasma/wallpapers/image/image.cpp
<http://reviewboard.vidsolbach.de/r/332/#comment269>

    if (model



trunk/KDE/kdebase/workspace/plasma/wallpapers/image/image.cpp
<http://reviewboard.vidsolbach.de/r/332/#comment270>

    if (model


- Aaron


On 2009-01-17 13:58:45, Beat Wolf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/332/
> -----------------------------------------------------------
> 
> (Updated 2009-01-17 13:58:45)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Partially solves the wish: http://bugs.kde.org/show_bug.cgi?id=177087
> If possible, shows the resolution of a wallpaper. For wallpaper packages, the best resolution the package can provide will be shown
> 
> In the screenshot, only the last wallpaper is a single image where the resolution can be shown.
> 
> Update:
> updated diff with the suggestion, don't have time to take a screenshot, but all the resolutions are shown
> 
> Update2:
> added correct screenshot
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgrounddelegate.h
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgrounddelegate.cpp
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundlistmodel.h
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundlistmodel.cpp
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundpackage.h
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/backgroundpackage.cpp
>   trunk/KDE/kdebase/workspace/plasma/wallpapers/image/image.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/332/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://reviewboard.vidsolbach.de/r/332/s/106/
> 
> 
> Thanks,
> 
> Beat
> 
>