Review Request: PATCH: Configuration Dialog for Turning off Notifications in the Panel

[guitarist198 at yahoo.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/331/
-----------------------------------------------------------

(Updated 2009-01-17 11:14:51.322646)


Review request for Plasma.


Summary
-------

This patch allows one to turn on and off jobs and notifications in the panel via the systemtray configuration dialog.  This is in response to Aaron Seigo's blog entry: http://aseigo.blogspot.com/2009/01/todays-tip-turning-off-fancy-schmancy.html

Within manager.cpp, functions to unregister the notification and job protocols was created, as well as a function to unset a protocol (disconnect it).  These were based on the already present functions to register and setup protocols.

Within applet.cpp, a new page was added to the configuration dialog called "Notifications."  This page includes the two check boxes that allow one to turn on and turn off notifications.  A possible area where that may need to be fixed is the strings for the check boxes.  Presently they are "Show Jobs" and "Show Notifications."

Thank you for your time and review.

Update:  I have attached a screenshot of what the configuration dialog looks like and I also made a change to the patch:  I added the i18n function around the check box label strings which I had forgotten the first time around.


Diffs
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/applet.cpp
  /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/core/manager.h
  /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/core/manager.cpp

Diff: http://reviewboard.vidsolbach.de/r/331/diff


Testing
-------

Testing of suppression of job progress.
Testing of suppression of notifications.
Testing of allowing job progress.
Testing of allowing notifications. 


Screenshots
-----------

Configuration Dialog
  http://reviewboard.vidsolbach.de/r/331/s/101/
Configuration Dialog With Description Text
  http://reviewboard.vidsolbach.de/r/331/s/105/


Thanks,

distortedlogic