Review Request: Styled input fields

Marco Martin notmart at gmail.com
Fri Jan 16 22:35:03 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/329/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

This makes input fields use plasma text color (maybe would not have a distinction between windowtext and text here to keep things simple?)
and a framesvg for painting (currently sunken frame, probably will need new graphics with also a nice focus effect)
since input fields are a thing that would be identic for every similar thing it's done in the plasma style, modified to create only framesvgs that actually needs
the combobox is still missing, but that's the idea :)


Diffs
-----

  /trunk/KDE/kdelibs/plasma/private/style.cpp
  /trunk/KDE/kdelibs/plasma/private/style_p.h
  /trunk/KDE/kdelibs/plasma/widgets/lineedit.h
  /trunk/KDE/kdelibs/plasma/widgets/lineedit.cpp
  /trunk/KDE/kdelibs/plasma/widgets/spinbox.h
  /trunk/KDE/kdelibs/plasma/widgets/spinbox.cpp

Diff: http://reviewboard.vidsolbach.de/r/329/diff


Testing
-------


Screenshots
-----------


  http://reviewboard.vidsolbach.de/r/329/s/99/


Thanks,

Marco



More information about the Plasma-devel mailing list