[PATCH] fixing krazy2 issues in kdeplasma-addons

Aaron J. Seigo aseigo at kde.org
Fri Jan 16 16:54:57 CET 2009


On Friday 16 January 2009, Philipp Klaffert wrote:
> Since I had some time I patched some of the minor krazy2 issues in
> kdeplasma-addons. Mostly the QLatin1String and double-quote issues.
> I attached the patch to this mail so feel free to look over it and if its
> Ok, please commit it since I am not able to do so...

i'm really not so much a fan of the QLatin1String changes. in these particular 
cases, they don't result in any useful performance improvements and they 
aren't technically incorrect, but they do impact readability. the rest of the 
changes look ok, however. =)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090116/9cb9c42b/attachment.sig 


More information about the Plasma-devel mailing list