[PATCH] fix for krazy2 issues [includes]
Bruno Bigras
bruno at burnbox.net
Tue Jan 13 22:58:31 CET 2009
This is for section #13 (Check for proper include directives [includes])
http://englishbreakfastnetwork.org/krazy/reports/kde-4.x/kdeplasma-addons/applets/index.html
It reduces the 62 issues to 2, which I think may be falses positives
since I see "config-lancelot.h" and not "Config.h".
this patch apply in ~/kdesvn/kdeplasma-addons/applets
------
remaining issues:
krazy2 Analysis
Checkers Run = 1
Files Processed = 339
Total Issues = 2 ...as of January 13 2009 16:40:48 EST
==>For File Type c++<==
1. Check for proper include directives [includes]... 2 issues found
./lancelot/app/src/QtDisplay.h: put config.h in angle brackets
line#24
./lancelot/app/src/QtDisplay.cpp: put config.h in angle brackets
line#22
Use <..> to include installed headers; <QtModule/QClass> to include
Qt headers from installed headers; cpp file should include their
own headers first (but below config.h); other rules apply, see
<http://techbase.kde.org/Policies/Library_Code_Policy#Getting_.23in
cludes_right>. Use include guards in headers with appropriatedly
encoded macro names.
http://lxr.kde.org/source/KDE/kdeplasma-addons/applets/lancelot/app/src/QtDisplay.cpp#22
http://lxr.kde.org/source/KDE/kdeplasma-addons/applets/lancelot/app/src/QtDisplay.h#24
--
Bruno
-------------- next part --------------
A non-text attachment was scrubbed...
Name: includes.diff
Type: text/x-diff
Size: 52326 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090113/bb3ce7ce/attachment-0001.bin
More information about the Plasma-devel
mailing list