Review Request: a little extra margin before the last items of the systray

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/324/#review312
-----------------------------------------------------------

Ship it!


the layout used in the system tray probably need to be re-thought out. but until then, this is fine by me. please add some comments there explaining what's going on though since in a month i'll look at this and have to re-read the code a lot to remember why it's there ;)

- Aaron


On 2009-01-08 13:28:49, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/324/
> -----------------------------------------------------------
> 
> (Updated 2009-01-08 13:28:49)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> adds a little empty item as a spacer that separates between the middle and last elements of the system tray, depending from the size of the framesvg brders
> this makes more visual balance of the gray background, having the same margin on both sides of the last icons
> dunno if it's worth the hassle since the patch is a bit complex for what it does, but definitely looks better
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/systemtray/ui/taskarea.cpp
> 
> Diff: http://reviewboard.vidsolbach.de/r/324/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco
> 
>