Review Request: Let PopupApplet show BusyWidget in popup

Artur de Souza (MoRpHeUz) morpheuz at gmail.com
Sat Feb 28 23:52:25 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/177/
-----------------------------------------------------------

(Updated 2009-02-28 14:52:24.624693)


Review request for Plasma and Aaron Seigo.


Changes
-------

Fixed the memory leak. Put inside the d pointer. richmoore and notmart reviewed it.


Summary
-------

Right now, PopupApplet can't show BusyWidget because it uses the applet's boundingRect. To make it work inside the popup of PopupApplet, we need to change some code inside Plasma::Applet to test if we have
popup and if this is true, if we should use widget() or graphicsWidget().


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/applet.cpp 933044 
  /trunk/KDE/kdelibs/plasma/private/applet_p.h 933044 

Diff: http://reviewboard.kde.org/r/177/diff


Testing
-------


Screenshots
-----------

busywidget
  http://reviewboard.kde.org/r/177/s/30/


Thanks,

Artur



More information about the Plasma-devel mailing list