Review Request: borders of Plasma::Dialog dependent on screen edges

Marco Martin notmart at gmail.com
Sat Feb 28 19:07:56 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/206/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

this makes all dialogs to not have the bottom border, not just the extender based ones.
also vertical borders are deactivated, this solves also the fitts law problem of kickoff


Diffs
-----

  /trunk/KDE/kdelibs/dialog.cpp 932222 

Diff: http://reviewboard.kde.org/r/206/diff


Testing
-------

it still has some problems combined with extenders, margins seem wrong in that case, needs investigation


Screenshots
-----------


  http://reviewboard.kde.org/r/206/s/43/


Thanks,

Marco



More information about the Plasma-devel mailing list