Review Request: Comic applet using Plasma::Widgets

[Matthias Fuchs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/145/
-----------------------------------------------------------

(Updated 2009-02-28 07:59:03.194514)


Review request for Plasma.


Changes
-------

The Label size does not change, it remains at the initial size. In the screenshot I initially looked at XKCD-strips (small ID-size and small url-size), now changing to Garfield resulted in too small Labels. Something like that is not the case with QWidgets and QLayout but here with Plasma::Label(a stretch in between) and QGraphicsLinearLayout it is.


Summary
-------

I converted the comic applet to use Plasma::Widgets and basically everything works nice.

I have some questions though:

* Is there a way to avoid recreating the layout (ComicApplet::createLayout() in this case )?
* Is there a way to add SpacerItems, so that mLabelId would be on the left of bottomLayout and only use as much space as needed, while mLabelUrl would be on the right and only use as much space needed as well?


Diffs
-----

  /trunk/KDE/kdeplasma-addons/applets/comic/CMakeLists.txt 930543 
  /trunk/KDE/kdeplasma-addons/applets/comic/arrowwidget.h PRE-CREATION 
  /trunk/KDE/kdeplasma-addons/applets/comic/arrowwidget.cpp PRE-CREATION 
  /trunk/KDE/kdeplasma-addons/applets/comic/comic.h 931593 
  /trunk/KDE/kdeplasma-addons/applets/comic/comic.cpp 931593 
  /trunk/KDE/kdeplasma-addons/applets/comic/imagewidget.h PRE-CREATION 
  /trunk/KDE/kdeplasma-addons/applets/comic/imagewidget.cpp PRE-CREATION 

Diff: http://reviewboard.kde.org/r/145/diff


Testing (updated)
-------

Plasma::Labels do not adapt to the size of the text here.


Screenshots
-----------


  http://reviewboard.kde.org/r/145/s/42/


Thanks,

Matthias