Review Request: Add fade effect to wallpaper plugin.

Matthew Dawson matthewjd at gmail.com
Thu Feb 26 22:52:20 CET 2009


Hello,

Unfortunately, reviewboard is not accepting this updated diff, so I'm posting it here.  I'm not sure why I thought it didn't work with single images, but it does now.  It also works in the configuration dialog box :).

Matthew

On Thursday 26 February 2009 16:02:31 Artur de Souza (MoRpHeUz) wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/195/#review287
> -----------------------------------------------------------
> 
> 
> Hmm...the idea is pretty nice. Why it doesn't work for single images wallpapers (just slideshow) ? Hehe, and this is the typical feature that is trivial to do with Qt Kinetic ;)
> 
> Cheers
> 
> - Artur
> 
> 
> On 2009-02-26 12:24:44, Matthew Dawson wrote:
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/195/
> > -----------------------------------------------------------
> > 
> > (Updated 2009-02-26 12:24:44)
> > 
> > 
> > Review request for Plasma.
> > 
> > 
> > Summary
> > -------
> > 
> > This patch makes the wallpaper plugin fade out the old wallpaper when it changes.  Currently the effect only works when in slideshow mode.
> > 
> > Video Demo:
> > http://mjdsystems.ca/fadedemo.ogv
> > 
> > 
> > This addresses bug 168731.
> >     https://bugs.kde.org/show_bug.cgi?id=168731
> > 
> > 
> > Diffs
> > -----
> > 
> >   /trunk/KDE/kdebase/workspace/plasma/wallpapers/image/image.h 932504 
> >   /trunk/KDE/kdebase/workspace/plasma/wallpapers/image/image.cpp 932504 
> > 
> > Diff: http://reviewboard.kde.org/r/195/diff
> > 
> > 
> > Testing
> > -------
> > 
> > Locally in Xephyr.
> > 
> > 
> > Thanks,
> > 
> > Matthew
> > 
> >
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: wallpaper2.diff
Type: text/x-diff
Size: 3443 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090226/ef5edefc/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090226/ef5edefc/attachment-0001.sig 


More information about the Plasma-devel mailing list