Review Request: Let PopupApplet show BusyWidget in popup

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/177/#review260
-----------------------------------------------------------


that's a god thing.
however, does it react to applet resize when is in a popup?
looking at it it remembers me that i must do a similar thing with config overlays, perhaps the busy widget could be put in a massage overlay an let a layout manage it, so the work would be done a single time? just a random idea

- Marco


On 2009-02-24 17:49:06, Artur de Souza (MoRpHeUz) wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/177/
> -----------------------------------------------------------
> 
> (Updated 2009-02-24 17:49:06)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> Right now, PopupApplet can't show BusyWidget because it uses the applet's boundingRect. To make it work inside the popup of PopupApplet, we need to change some code inside Plasma::Applet to test if we have
> popup and if this is true, if we should use widget() or graphicsWidget().
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/applet.cpp 929009 
> 
> Diff: http://reviewboard.kde.org/r/177/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> busywidget
>   http://reviewboard.kde.org/r/177/s/30/
> 
> 
> Thanks,
> 
> Artur
> 
>