Review Request: manage layout direction in the layoutwidget of the tasks applet

Aaron Seigo aseigo at kde.org
Mon Feb 23 20:41:48 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/169/#review251
-----------------------------------------------------------

Ship it!


sensible steps forward


/trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.h
<http://reviewboard.kde.org/r/169/#comment143>

    indentation wrong </nitpick> :)



/trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.cpp
<http://reviewboard.kde.org/r/169/#comment144>

    indetation.


- Aaron


On 2009-02-23 10:48:37, Christian Mollekopf wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/169/
> -----------------------------------------------------------
> 
> (Updated 2009-02-23 10:48:37)
> 
> 
> Review request for Plasma, Aaron Seigo and Marco Martin.
> 
> 
> Summary
> -------
> 
> This patch enables the LayoutWidget of the Tasks applet to have another layout direction than the applet itself.
> This is a preparation for the popup since we want there the popup to be vertical for a horizontal taskbar.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.h 930522 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.cpp 930522 
>   /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 930522 
> 
> Diff: http://reviewboard.kde.org/r/169/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christian
> 
>



More information about the Plasma-devel mailing list