Review Request: Turn the LayoutWidget in the Tasks applet into a QGraphicsGridLayout subclass

Christian Mollekopf chrigi_1 at
Wed Feb 18 20:10:26 CET 2009

This is an automatically generated e-mail. To reply, visit:

Review request for Plasma, Aaron Seigo and Marco Martin.


Since the gridlayout got fixed in qt 4.5 it's not anymore necessary to recreate the layout every time.
Therefore this patch turns the LayoutWidget into a QGraphicsGridLayout (which was my original intetion).
This should make it also easier to implement the popup with real items instead of the current implementation.
I'm actually not sure if the call to LayoutWidget::layoutItems from the TaskGroupItem is the perfect solution but it's necessary because the rows are not recalculated otherwise.


  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.h 927988 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/layoutwidget.cpp 927988 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 927988 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 927988 



Tested locally, no backdrafts found



More information about the Plasma-devel mailing list