Review Request: Make tools use all the available width

Marco Martin notmart at gmail.com
Sat Feb 14 18:17:43 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/77/#review105
-----------------------------------------------------------

Ship it!


i think it looks better, like it :)


/trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp
<http://reviewboard.kde.org/r/77/#comment69>

    maybe KIconLoader::SizeSmallMedium instead of 22?
    


- Marco


On 2009-02-14 08:30:12, Artur de Souza (MoRpHeUz) wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/77/
> -----------------------------------------------------------
> 
> (Updated 2009-02-14 08:30:12)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This patch makes each tool (action) inside a toolbox use all the width available, giving a better UI effect. Before, each tool had it's own width giving a sensation of 'mess' =). Attached the screenshot with the new behavior. Please, ignore the svg problems as it's being held by other people.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/private/desktoptoolbox.cpp 925684 
> 
> Diff: http://reviewboard.kde.org/r/77/diff
> 
> 
> Testing
> -------
> 
> Currently using this with trunk
> 
> 
> Screenshots
> -----------
> 
> using the available width
>   http://reviewboard.kde.org/r/77/s/11/
> 
> 
> Thanks,
> 
> Artur
> 
>



More information about the Plasma-devel mailing list