KDE/kdelibs/plasma/widgets

[Marco Martin]

On 2/9/09, Dan Meltzer <parallelgrapefruit at gmail.com> wrote:
> On Mon, Feb 9, 2009 at 11:09 AM, Marco Martin <notmart at gmail.com> wrote:
>> SVN commit 923865 by mart:
>>
>> a bit of comments doesn't hurt
> (Yay, random api review based on comments!)
>
>
>>
>>
>>  M  +48 -2     videowidget.h
>>
>>
>> --- trunk/KDE/kdelibs/plasma/widgets/videowidget.h #923864:923865
>> @@ -37,8 +37,11 @@
>>
>>  /**
>>  * @class VideoWidget plasma/widgets/videowidget.h
>> <Plasma/Widgets/VideoWidget>
>> + * a Video playing widget via Phonon, it encloses the
>> + * Phonon::MediaObject and Phonon::AudioOutput too
>>  *
>>  * @short Provides a video player widget
>> + * @since KDE4.3
>>  */
>>  class PLASMA_EXPORT VideoWidget : public QGraphicsProxyWidget
>>  {
>> @@ -54,20 +57,42 @@
>>     explicit VideoWidget(QGraphicsWidget *parent = 0);
>>     ~VideoWidget();
>>
>> +    /**
>> +     * Choose what file to play
>> +     * @arg path resource to play
>> +     */
>>     void setFile(const QString &path);
>
> Would it make more sense to have this take either a KUrl or a
> Phonon::MediaSource? I'd think the latter would be ideal, but the
> former would at least provide a hint that it can play remote media as
> well.
that could be a good idea, i would go with the KUrl, for setting the
mediasource it's always possible to go with accessing the mediaobject

>>
>> -    //TODO: decide ifsupporting just file from the api or even just make
>> use just MediaObject wtith no api here
>> +    /**
>> +     * @return the file we are playing
>> +     */
>>     QString file() const;
>>
>> +    /**
>> +     * @return the Phonon::MediaObject being used
>> +     * @see Phonon::MediaObject
>> +     */
>>     Q_INVOKABLE Phonon::MediaObject *mediaObject() const;
>
> If you are providing access to the mediaObject is it necessary to have
> all the functions that wrap it?  (I guess this is what the comment is
> about below, but wouldn't it make more sense to see about getting
> script bindings for Phonon rather than wrapping it here (and anywhere
> else that may need scripted phonon stuff)

don't know, i'm really really unsure about that, i would go like other
plasma widgets that have a minimal set of wrapped stuff to be really
easy (the javascript test that actually plays video is exactly 5 lines
long)
this is an open question: i'm asking to everybody: opinions how it should be?

cheers,
Marco Martin

> Dan,
>>
>> +    /**
>> +     * @return the Phonon::AudioOutput being used
>> +     * @see Phonon::AudioOutput
>> +     */
>>     Q_INVOKABLE Phonon::AudioOutput *audioOutput() const;
>>
>> -    //FIXME: bunch of stuff wrapped from MediaObject: makes sense for
>> scripting or just use MediaObject also for scripts?
>> +    /**
>> +     * @return the current time of the current media file
>> +     */
>>     qint64 currentTime() const;
>>
>> +    /**
>> +     * @return the total playing time of the current media file
>> +     */
>>     qint64 totalTime() const;
>>
>> +    /**
>> +     * @return the time remaining to the current media file
>> +     */
>>     qint64 remainingTime() const;
>>
>>     /**
>> @@ -88,16 +113,37 @@
>>     Phonon::VideoWidget *nativeWidget() const;
>>
>>  public Q_SLOTS:
>> +    /**
>> +     * Play the current file
>> +     */
>>     void play();
>>
>> +    /**
>> +     * Pause the current file
>> +     */
>>     void pause();
>>
>> +    /**
>> +     * Stop the current file
>> +     */
>>     void stop();
>>
>> +    /**
>> +     * Jump at a given millisecond in the current file
>> +     * @arg time where we want to jump
>> +     */
>>     void seek(qint64 time);
>>
>>  Q_SIGNALS:
>> +    /**
>> +     * Emitted regularly when the playing is progressing
>> +     * @arg time where we are
>> +     */
>>     void tick(qint64 time);
>> +
>> +    /**
>> +     * Emitted an instant before the playback is finished
>> +     */
>>     void aboutToFinish();
>>
>>  private:
>>
> _______________________________________________
> Plasma-devel mailing list
> Plasma-devel at kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>