[PATCH] Lock/Logout plasmoid: configure shown buttons

[Sebastian Kügler]

On Sunday 08 February 2009 15:08:13 Konstantinos Smanis wrote:
> I have created a patch that implements wishlist #164687
> (https://bugs.kde.org/show_bug.cgi?id=164687), namely provide the UI to
> configure the buttons which are shown in the Lock/Logout plasmoid (Lock,
> Logout or both).
>
> I wasn't sure whether I should commit it (plasma is quite a "sensitive"
> area that I wouldn't like to mess), so I send it to you, the Plasma devs to
> review it. It's quite small btw.
>
> I have followed the coding styles and all these things, but there were some
> things that I wasn't sure for. For example, under Windows the logout button
> is not shown so the configuration UI should not apply there. Thus I have
> put all config-related code in the appropriate #ifndef Q_OS_WIN. Still, I
> don't really like this (I am afraid I abused it and spread it all over the
> code), so feel free to make suggestions.

Member vars should be prefixed with m_ and camel-cased (so icon_lock -> 
m_iconLock, icon_logout -> m_iconLogout). Otherwise, I don't see anything 
glaringly wrong with this patch.

A nice addition would be allowing to show shutdown, restart, suspend and 
hibernate buttons as well.
-- 
sebas

 http://www.kde.org | http://vizZzion.org |  GPG Key ID: 9119 0EF9