Review Request: add method addIconAction(QAction*, ActionCorner) to Plasma::IconWidget plus a bonus :)
Alessandro Diaferia
alediaferia at gmail.com
Wed Feb 4 19:26:49 CET 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/14/
-----------------------------------------------------------
(Updated 2009-02-04 10:26:49.516411)
Review request for Plasma, Aaron Seigo and Marco Martin.
Changes
-------
a more sane free corner retrieval.
Summary
-------
This patch adds the chance to specify in which corner the action will be placed. Useful for me in the devicenotifier refactor. In addition to this i've fixed the fact that the action is painted on the *widget*'s corner and not on the *icon*'s corner. To achieve this i used a workaround, but i don't like it much even if it correctly does the trick.
I hope that everything is still BC.
Lemme know what you think about this.
Cheers :)
Diffs (updated)
-----
trunk/KDE/kdelibs/plasma/widgets/iconwidget.h 920669
trunk/KDE/kdelibs/plasma/widgets/iconwidget.cpp 920669
trunk/KDE/kdelibs/plasma/widgets/iconwidget_p.h 920669
Diff: http://reviewboard.kde.org/r/14/diff
Testing
-------
Thanks,
Alessandro
More information about the Plasma-devel
mailing list