Review Request: Show the currently selected sensor in bubblemon applet settings

Shantanu Tushar Jha jhahoneyk at gmail.com
Wed Dec 30 17:05:40 CET 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2464/#review3532
-----------------------------------------------------------



trunk/KDE/kdeplasma-addons/applets/bubblemon/src/bubble.cpp
<http://reviewboard.kde.org/r/2464/#comment2816>

    This should be moved to follow line 455 so that scrolling only occurs if the currentSensor is valid.


- Shantanu


On 2009-12-30 15:42:25, sudhendu kumar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2464/
> -----------------------------------------------------------
> 
> (Updated 2009-12-30 15:42:25)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> The patch shows the currently selected sensor in bubblemon applet settings dialog.
> Previously it was difficult for the user to make out which sensor was selected.The patch scrolls to the currently selected sensor.
> Hope this is fine, it's my first patch.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdeplasma-addons/applets/bubblemon/src/bubble.cpp 1067555 
> 
> Diff: http://reviewboard.kde.org/r/2464/diff
> 
> 
> Testing
> -------
> 
> Tested on trunk.The patch works correctly.
> 
> 
> Thanks,
> 
> sudhendu
> 
>



More information about the Plasma-devel mailing list