Review Request: Plasma::ScrollWidget: One liner fix for segmentation fault when using "Preferred" as size policy

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2379/#review3429
-----------------------------------------------------------


this was almost right...
in the end, seemed a cyclical layout invalidate, it's hopefully corrected in r1062764

- Marco


On 2009-12-15 19:05:25, Bruno Abinader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2379/
> -----------------------------------------------------------
> 
> (Updated 2009-12-15 19:05:25)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Summary
> -------
> 
> This patch fixes a segmentation fault ( https://bugs.kde.org/show_bug.cgi?id=202890 ) when using Plasma::ScrollWidget() under certain circumstances (i.e. when using "Preferred" as size policy for a ScrollWidget or when using a widget style != oxygen).
> 
> 
> This addresses bug 202890.
>     https://bugs.kde.org/show_bug.cgi?id=202890
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp 1062690 
> 
> Diff: http://reviewboard.kde.org/r/2379/diff
> 
> 
> Testing
> -------
> 
> I've tested this patch and now when using a widget style different from oxygen (QtCurve) or using "Preferred" as unique size policy, both situations behaved normally.
> 
> 
> Thanks,
> 
> Bruno
> 
>