Review Request: update the data when the predicate files change
Giulio Camuffo
giuliocamuffo at gmail.com
Mon Dec 7 17:00:35 CET 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2331/
-----------------------------------------------------------
(Updated 2009-12-07 16:00:35.486601)
Review request for Plasma and Aaron Seigo.
Changes
-------
using dirty() instead of created() and deleted(), so it reacts to the changes of the files too.
Summary
-------
This patch uses a KDirWatch to watch the folders where the predicate files are in. If one of them gets created, modified, deleted, it updates its data so the applets using it receive a dataUpdated() and can adjust their things.
Diffs (updated)
-----
/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/hotplug/CMakeLists.txt 1059391
/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/hotplug/hotplugengine.h 1059391
/trunk/KDE/kdebase/workspace/plasma/generic/dataengines/hotplug/hotplugengine.cpp 1059391
Diff: http://reviewboard.kde.org/r/2331/diff
Testing
-------
tested, works. the notifier changes its "x actions for this device" instantly. (the notifier needs a fix for it anyway, since the actions themselves aren't changed. i'll do it once this is committed)
Thanks,
Giulio
More information about the Plasma-devel
mailing list