Review Request: Keyboard navigation support for Tasks applet

Michal Dutkiewicz emdeck at gmail.com
Mon Aug 31 18:03:47 CEST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1482/
-----------------------------------------------------------

(Updated 2009-08-31 16:03:46.974286)


Review request for Plasma, Aaron Seigo and Marco Martin.


Changes
-------

Use available methods instead querying layout directly and possible optimization when there is only one task.


Summary
-------

This patch adds support for [Shift + ] Tab navigation (and Enter / Return to activate item) in Tasks plasmoid.
In order to work it needs fixing of panel focusing issue (as discussed on mailing list), I could apply mine method for temporary use if needed.


Diffs (updated)
-----

  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h 1017535 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp 1017535 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 1017535 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 1017535 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.h 1017535 
  /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp 1017535 

Diff: http://reviewboard.kde.org/r/1482/diff


Testing
-------

Tested in plasmoidviwer and works (groups may need additional testing).


Thanks,

Michal



More information about the Plasma-devel mailing list