Review Request: Quicklaunch: Fix config UI where mouse wheeling on slider does not change spinbox value

Beat Wolf asraniel at fryx.ch
Mon Aug 31 14:13:12 CEST 2009



> On 2009-08-02 23:52:28, Aaron Seigo wrote:
> > good catch :)
> 
> Shafqat Bhuiyan wrote:
>     Thanks :)
>     
>     It would be great if you could commit this one as well :)

this patch is commited and should be marked like that


- Beat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1221/#review1886
-----------------------------------------------------------


On 2009-08-02 23:42:14, Shafqat Bhuiyan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1221/
> -----------------------------------------------------------
> 
> (Updated 2009-08-02 23:42:14)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> This changes the slider signals which connect to the spinboxes from sliderMoved(int) to valueChanged(int) in the quicklaunch configuration window. This fixes the problem where mouse wheeling on the slider does not change the spinbox.
> 
> This should be backported to 4.3
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchConfig.ui 1004927 
> 
> Diff: http://reviewboard.kde.org/r/1221/diff
> 
> 
> Testing
> -------
> 
> Tested on trunk
> 
> 
> Thanks,
> 
> Shafqat
> 
>



More information about the Plasma-devel mailing list