Review Request: Custom combo boxes for Plasma::ComboBox

[Michal Dutkiewicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1094/
-----------------------------------------------------------

(Updated 2009-08-30 16:39:32.923467)


Review request for Plasma, Aaron Seigo and Marco Martin.


Changes
-------

New approach, constructor replaced by setNativeWidget() method.

It's time to decide which widgets should also have this method, personally I think that at least LineEdit, SpinBox, TextEdit should have it (others usually are not sub classed, at least as far as I know).


Summary (updated)
-------

This patch adds possibility to use custom combo box widgets (sub classed from KComboBox) instead of plain KComboBox.


Diffs (updated)
-----

  /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1016281 
  /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1016281 

Diff: http://reviewboard.kde.org/r/1094/diff


Testing (updated)
-------

Compiles and should work, but not tested.


Screenshots
-----------

Plasma themed KHistoryComboBox in Run Command applet
  http://reviewboard.kde.org/r/1094/s/151/


Thanks,

Michal