Review Request: Center tool tips in Plasma

[Aaron J. Seigo]

On August 29, 2009, Emdek wrote:
> On 29-08-2009 at 13:06:20 Aaron J. Seigo <aseigo at kde.org> wrote:
> > On August 29, 2009, Michal Dutkiewicz wrote:
> >> > On 2009-08-28 21:42:20, Aaron Seigo wrote:
> >> > > /trunk/KDE/kdelibs/plasma/corona.cpp, line 511
> >>
> >> <http://reviewboard.kde.org/r/1428/diff/1/?file=10799#file10799line511>
> >>
> >> > >     i thought we were going to avoid the bool and instead use
> >> > > Qt::Alignment?
> >>
> >> So only one public method with optional Alignment flag (by default
> >> alignment would be as now, usually to left edge etc.) and for now
> >> accepting
> >> only Qt::AlignCenter?
> >
> > well, center, left and right imo.
>
> And then what again with bottom and top for vertical oriented widgets?

i think just left/right/center should be supported and that should be 
translated to top/bottom/vcenter for vertical widgest. that way widgets aren't 
encouraged to try and figure out their orientations.

> And that left and right shouldn't be decided by language (RTL and LTR)?

as long as it fits on screen, direction should be flipped in RTL.

> For me there should be option only to center (useful for tool tips and at
> least some popups) or to use current behavior (menus).

there are likely times that right aligned will be desired, and it provides 
nice API symmetry. most importantly it avoids bools in the API. :)

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Qt Software
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
Url : http://mail.kde.org/pipermail/plasma-devel/attachments/20090829/321bd0c4/attachment.sig