Review Request: Center tool tips in Plasma

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1428/#review2173
-----------------------------------------------------------



/trunk/KDE/kdelibs/plasma/corona.h
<http://reviewboard.kde.org/r/1428/#comment1482>

    may as well make it public with the other popupPosition; it needs apidox with an @since as well :)



/trunk/KDE/kdelibs/plasma/corona.cpp
<http://reviewboard.kde.org/r/1428/#comment1483>

    i thought we were going to avoid the bool and instead use Qt::Alignment?


- Aaron


On 2009-08-28 20:26:02, Michal Dutkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1428/
> -----------------------------------------------------------
> 
> (Updated 2009-08-28 20:26:02)
> 
> 
> Review request for Plasma and Aaron Seigo.
> 
> 
> Summary
> -------
> 
> This patch aims to provide centered tool tips for Plasma (aligned to edge in some cases looks bad).
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/plasma/corona.h 1016281 
>   /trunk/KDE/kdelibs/plasma/corona.cpp 1016281 
>   /trunk/KDE/kdelibs/plasma/tooltipmanager.cpp 1016281 
> 
> Diff: http://reviewboard.kde.org/r/1428/diff
> 
> 
> Testing
> -------
> 
> Tested only if compile, not tested if works (can't compile full trunk now... problems with Akonadi), relies on commented out code to center popups.
> 
> 
> Thanks,
> 
> Michal
> 
>