Review Request: Condition icons for the NOAA weather ion

[Shawn Starr]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1418/#review2170
-----------------------------------------------------------

Ship it!


Looks good to me, SHIP IT!

- Shawn


On 2009-08-28 01:11:00, Amos Kariuki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1418/
> -----------------------------------------------------------
> 
> (Updated 2009-08-28 01:11:00)
> 
> 
> Review request for Plasma and Shawn Starr.
> 
> 
> Summary
> -------
> 
> Possible patch to allow the NOAA weather ion to determine the weather condition icon as defined at <http://www.weather.gov/xml/current_obs/weather.php>  This allows it to work with the weather-wallpaper plasmoid as well as display the condition icon in the weather plasmoid.  Categorization/mappings of condition to icon are arbitrary (as I saw fit) so feel free to point out any improvements or errors.
> 
> Questions:
> a) Minor issue: Seems like the interface to IonInterface::getWeatherIcon(const QMap<QString, ConditionIcons> &conditionList, const QString& condition) is a bit restrictive since it's making assumptions that the implementors of IonInterface are using a list to manage their condition icons (the submitted patch doesn't). Wouldn't it be more flexible for it to only require an IonInterface::ConditionIcons as an argument, or maybe overload it for compatibility purposes?
> 
> b) Noticed that conditions icon files for weather-scattered-storms-night and weather-scattered-storms-day are missing.  Not sure if this is a work in progress or if the corresponding ChanceThunderstormDay/Night are deprectaed; anyway, the patch includes them for now.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion.h 1016161 
>   trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion.cpp 1016161 
>   trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_noaa.h 1016161 
>   trunk/KDE/kdebase/workspace/plasma/dataengines/weather/ions/ion_noaa.cpp 1016161 
> 
> Diff: http://reviewboard.kde.org/r/1418/diff
> 
> 
> Testing
> -------
> 
> Tested with a number of random locations and compared them to the reported weather condition on NOAA's website.
> 
> 
> Thanks,
> 
> Amos
> 
>