Review Request: reimplement adding application launcher submenus to panels and desktops

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1389/#review2130
-----------------------------------------------------------

Ship it!


rocking; this will make a few more people happy :)

- Aaron


On 2009-08-23 19:51:22, Will Stephenson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1389/
> -----------------------------------------------------------
> 
> (Updated 2009-08-23 19:51:22)
> 
> 
> Review request for Plasma.
> 
> 
> Summary
> -------
> 
> Make it possible to add Kickoff and simple-launcher submenus to panels and desktops.  
> 
> This works by storing the relative path and icon name of KServiceGroups (== submenus) in the application model used by the menu
> 
> When an 'Add to Panel/Desktop' context menu action is triggered, add a simplelauncher applet (instead of an Icon).
> 
> This receives the relative path of the submenu and the icon name in its args, and when it builds its menu, it walks the applications model and locates the submenu, rooting the menu at that index rather than the real root, and setting the icon for the launcher to that of the submenu.
> 
> When the applet is showing a submenu, the view types  and number of recent applications to shown are not shown in the config UI.
> 
> TODO: set tooltip to title of submenu instead of 'Application Launcher Menu'.
> 
> 
> This addresses bug 189583.
>     https://bugs.kde.org/show_bug.cgi?id=189583
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/contextmenufactory.cpp 1013494 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/simpleapplet.cpp 1013494 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp 1013494 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/models.h 1013494 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/menuview.h 1013494 
>   trunk/KDE/kdebase/workspace/plasma/applets/kickoff/simpleapplet/menuview.cpp 1013494 
> 
> Diff: http://reviewboard.kde.org/r/1389/diff
> 
> 
> Testing
> -------
> 
> Add submenus
> 
> Add sub-submenus
> 
> Add as desktop icon
> 
> Add as panel icon
> 
> Quit and restart Plasma
> 
> Reconfigure application launchers
>   Menu titles
>   Description vs app name
>   Icons
> 
> 
> Thanks,
> 
> Will
> 
>