Review Request: Add setSubTitlePolicy() method to Plasma::Delegate
Dmitry Suzdalev
dimsuz at gmail.com
Fri Aug 21 17:50:26 CEST 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1357/
-----------------------------------------------------------
(Updated 2009-08-21 15:50:26.488754)
Review request for Plasma, Aaron Seigo and Marco Martin.
Changes
-------
Updated patch as discussed with mart on irc: removed the API addition, left only logic that disables auto-addition of subtitles to non-unique items - disabling is done if model does provide some valid data for SubTitleMandatoryRole. This indicates model wants to have a full control for subtitle visibility.
Summary
-------
This adds more control of showing subtitles with Plasma::Delegate by adding a setSubtitlePolicy() method to its API.
Discussed briefly on #plasma with notmart, now on to review :)
Diffs (updated)
-----
trunk/KDE/kdelibs/plasma/delegate.h 1010706
trunk/KDE/kdelibs/plasma/delegate.cpp 1010706
Diff: http://reviewboard.kde.org/r/1357/diff
Testing
-------
Tested with klipper applet by putting it in all modes possible (at least all i can come up with :))
Thanks,
Dmitry
More information about the Plasma-devel
mailing list